aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-08-30about to add cursor warpBryson Steck
2022-07-10add gapsBryson Steck
2022-05-10sync latest drw.{c,h} changes from dmenuHiltjo Posthuma
2022-05-01Makefile: add manual path for OpenBSDHiltjo Posthuma
Reported by fossy <fossy@dnmx.org>, thanks
2022-04-26manage: Make sure c->isfixed is applied before floating checksChris Down
Commit 8806b6e23793 ("manage: propertynotify: Reduce cost of unused size hints") mistakenly removed an early size hints update that's needed to populate c->isfixed for floating checks at manage() time. This resulted in fixed (size hint min dimensions == max dimensions) subset of windows not floating when they should. See https://lists.suckless.org/dev/2204/34730.html for discussion.
2022-04-26LICENSE: add Chris DownHiltjo Posthuma
2022-04-26Revert "manage: For isfloating/oldstate check/set, ensure trans client ↵Hiltjo Posthuma
actually exists" This reverts commit bece862a0fc4fc18ef9065b18cd28e2032d0d975. It caused a regression, for example: https://lists.suckless.org/hackers/2203/18220.html
2022-04-16Update monitor positions also on removalSanttu Lakkala
When monitors are removed, the coordinates of existing monitors may change, if the removed monitors had smaller coordinates than the remaining ones. Remove special case handling so that the same update-if-necessary loop is run also in the case when monitors are removed.
2022-04-16manage: propertynotify: Reduce cost of unused size hintsChris Down
This patch defers all size hint calculations until they are actually needed, drastically reducing the number of calls to updatesizehints(), which can be expensive when called repeatedly (as it currently is during resizes). In my unscientific testing this reduces calls to updatesizehints() by over 90% during a typical work session. There are no functional changes for users other than an increase in responsiveness after resizes and a reduction in CPU time. In slower environments or X servers, this patch also offers an improvement in responsiveness that is often tangible after resizing a client that changes hints during resizes. There are two main motivations to defer this work to the time of hint application: 1. Some clients, especially terminals using incremental size hints, resend XA_WM_NORMAL_HINTS events on resize to avoid fighting with the WM or mouse resizing. For example, some terminals like urxvt clear PBaseSize and PResizeInc during XResizeWindow and restore them afterwards. For this reason, after the resize is concluded, we typically receive a backlogged XA_WM_NORMAL_HINTS message for each update period with movement, which is useless. In some cases one may get hundreds or thousands of XA_WM_NORMAL_HINTS messages on large resizes, and currently all of these result in a separate updatesizehints() call, of which all but the final one are immediately outdated. (We can't just blindly discard these messages during resizes like we do for EnterNotify, because some of them might actually be for other windows, and may not be XA_WM_NORMAL_HINTS events.) 2. For users which use resizehints=0 most of these updates are unused anyway -- in the normal case where the client is not floating these values won't be used, so there's no need to calculate them up front. A synthetic test using the mouse to resize a floating terminal window from roughly 256x256 to 1024x1024 and back again shows that the number of calls to updatesizehints() goes from over 500 before this patch (one for each update interval with movement) to 2 after this patch (one for each hint application), with no change in user visible behaviour. This also reduces the delay before dwm is ready to process new events again after a large resize on such a client, as it avoids the thundering herd of updatesizehints() calls when hundreds of backlogged XA_WM_NORMAL_HINTS messages appear at once after a resize is finished.
2022-03-13manage: For isfloating/oldstate check/set, ensure trans client actually existsMiles Alan
In certain instances trans may be set to a window that doesn't actually map to a client via wintoclient; in this case it doesn't make sense to set isfloating/oldstate since trans is essentially invalid in that case / correlates to the above condition check where trans is set / XGetTransientForHint is called.
2022-03-13fix mem leak in cleanup()NRK
maybe leak isn't the best word, given that the object lives for the entire duration of the program's lifetime. however, all elements of scheme are free-ed, can't think of any reason why scheme itself should be an exception.
2022-01-07bump version to 6.3Hiltjo Posthuma
2021-12-19drawbar: Don't expend effort drawing bar if it is occludedChris Down
I noticed that a non-trivial amount of dwm's work on my machine was from drw_text, which seemed weird, because I have the bar disabled and we only use drw_text as part of bar drawing. Looking more closely, I realised that while we use m->showbar when updating the monitor bar margins, but don't skip actually drawing the bar if it is hidden. This patch skips drawing it entirely if that is the case. On my machine, this takes 10% of dwm's on-CPU time, primarily from restack() and focus(). When the bar is toggled on again, the X server will generate an Expose event, and we'll redraw the bar as normal as part of expose().
2021-08-20Revert "Improve speed of drw_text when provided with large strings"Hiltjo Posthuma
This reverts commit 716233534b35f74dba5a46ade8f1a6f8cc72fea4. It causes issues with truncation of characters when the text does not fit and so on. The patch should be reworked and properly tested.
2021-08-09Improve speed of drw_text when provided with large stringsMiles Alan
Calculates len & ew in drw_font_getexts loop by incrementing instead of decrementing; as such avoids proportional increase in time spent in loop based on provided strings size.
2021-07-14Add a configuration option for fullscreen lockingQuentin Rameau
Some people are annoyed to have this new behaviour forced for some application which use fake fullscreen.
2021-03-29Do not allow focus to drift from fullscreen client via focusstack()Chris Down
It generally doesn't make much sense to allow focusstack() to navigate away from the selected fullscreen client, as you can't even see which client you're selecting behind it. I have had this up for a while on the wiki as a separate patch[0], but it seems reasonable to avoid this behaviour in dwm mainline, since I'm struggling to think of any reason to navigate away from a fullscreen client other than a mistake. 0: https://dwm.suckless.org/patches/alwaysfullscreen/
2020-08-21Fix x coordinate calculation in buttonpress.Ian Remmler
2020-07-08dwm.1: fix wrong text in man pageHiltjo Posthuma
2020-06-11Fix memory leaks in drwAlex Flierl
The function drw_fontset_free in drw.c was never called.
2020-04-25dwm crashes when opening 50+ clients (tile layout)bakkeby
Many users new to dwm find themselves caught out by being kicked out to the login manager (dwm crashing) when they open 50+ clients for demonstration purposes. The number of clients reported varies depending on the resolution of the monitor. The cause of this is due to how the default tile layout calculates the height of the next client based on the position of the previous client. Because clients have a minimum size the (ty) position can exceed that of the window height, resulting in (m->wh - ty) becoming negative. The negative height stored as an unsigned int results in a very large height ultimately resulting in dwm crashing. This patch adds safeguards to prevent the ty and my positions from exceeding that of the window height.
2020-04-22drawbar: Don't shadow sw globalChris Down
This jarred me a bit while reading the code, since "sw" usually refers to the global screen geometry, but in drawbar() only it refers to text-related geometry. Renaming it makes it more obvious that these are not related.
2020-04-22getatomprop: Add forward declarationChris Down
No functional changes, but for every other function we have a forward declaration here. getatomprop should be no exception.
2020-04-20setmfact: Unify bounds for compile-time and runtime mfactChris Down
There are two places that mfact can be set: - In the mfact global, which is defined at compile time and passed into m->mfact during monitor setup. No bounds checks are performed, but the comment alongside it says that valid values are [0.05..0.95]: static const float mfact = 0.55; /* factor of master area size [0.05..0.95] */ - By setmfact, which adjusts m->mfact at runtime. It also does some minimum and maximum bounds checks, allowing [0.1..0.9]. Values outside of that range are ignored, and mfact is not adjusted. These different thresholds mean that one cannot setmfact 0.95 or 0.05, despite the comment above that lists the legal range for mfact. Clarify this by enforcing the same bounds in setmfact at runtime as those listed for mfact at compile time.
2020-04-03config.mk: fix POSIX_C_SOURCE macro for feature test for snprintf()Hiltjo Posthuma
The feature test was incorrect: _POSIX_C_SOURCE=2 "The value 2 or greater additionally exposes definitions for POSIX.2-1992." http://man7.org/linux/man-pages/man7/feature_test_macros.7.html A higher value is needed (atleast 1995): https://pubs.opengroup.org/onlinepubs/9699919799/functions/snprintf.html FreeBSD feature test macro: on https://github.com/freebsd/freebsd/blob/master/include/stdio.h line 297 This was already fixed in dmenu. This fixes a warning on FreeBSD, reported by Plasmoduck on IRC, thanks.
2019-02-02Prepare 6.2 release.Anselm R Garbe
2018-06-02pledge: add rpath promise for the ugly Xft font fallbackHiltjo Posthuma
2018-06-02Makefile: just show the compiler outputHiltjo Posthuma
Don't be fancy and just show the actual output so debugging is simpler.
2018-06-02Do not strip at link stageKlemens Nanni
Building with debug symbols is worthless unless LDFLAGS are manually adjusted as well.
2018-05-25Pledge on OpenBSDKlemens Nanni
2018-05-25config.def.h: ClkTagBar missing from commentHiltjo Posthuma
by Christopher Drelich <cd@cdrakka.com> Patch was mangled on the ML, also adjusted the order to be the same as the enum in dwm.c
2018-05-12Function declarations in correct order.Christopher Drelich
In dwm.c function declarations are in alphabetical order except for updategeom(). There doesn't appear to be any reason for this, so this patch corrects that, and now all function declarations are in alphabetical order.
2018-05-12remove old TODO and BUGS entriesHiltjo Posthuma
the bug in the dwm man page is an (ancient) Java issue. Thanks David and quinq for the patches and feedback!
2018-03-14update README: remove mentioning the old dextra repoHiltjo Posthuma
Thanks Christopher Drelich <cd@cdrakka.com>
2018-03-14All functions in alphabetical order except for this one.Christopher Drelich
2018-03-14ColBorder has been moved to the enum with ColFg and ColBg.Christopher Drelich
2017-12-27dont NUL terminate _NET_WM_NAMEHiltjo Posthuma
Reported by Kernc, thanks! "This makes a particular program that uses libwnck [1] fail after: Wnck-WARNING **: Property _NET_WM_NAME contained invalid UTF-8 in this code [2] because the returned string contains a '\0' and the documentation for g_utf8_validate() [3] explicitly states that when string length is provided, no nul bytes are allowed." It is not entirely clear it is incorrect, other WM's seem to not NUL terminate it either though.
2017-11-03sync dmenu drw.{c,h} code: use Clr* (was Scm)Hiltjo Posthuma
2017-11-03gettextprop: check result of XGetTextProperty (undefined behaviour for XFree)Hiltjo Posthuma
2017-11-03Set class name on status barOmar Sandoval
This is useful for configuring compositors to ignore the status bar window.
2017-10-11simplify isfixed conditionsDaniel Cousens
2017-05-08yet another cleanupAnselm R Garbe
The previous patches introduced some unclean space-based indentation patterns. This patch fixes them.
2017-03-28Don't restrict snap in mousemoveMarkus Teich
This also fixes a bug where client windows only switch to floating mode when the mouse is dragged in one specific direction.
2017-03-28Button passthrough when client is not focusedMarkus Teich
Before this change it is not possible to press a button in a client on the first click if the client is not yet focused. The first click on the button would only focus the client and a second click on the button is needed to activate it. This situation can occur when moving the mouse over a client (therefore focusing it) and then moving the focus to another client with keyboard shortcuts. After this commit the behavior is fixed and button presses on unfocused clients are passed to the client correctly.
2017-03-28cleanupMarkus Teich
- unify multi-line expression alignment style. - unify multi-line function call alignment style. - simplify client moving on monitor count decrease. - clarify comment for focusin(). - remove old confusing comment about input focus fix in focusmon(). The explanation is already in the old commit message, so no need to keep it in the code. - remove old comment describing even older state of the code in focus(). - unify comment style. - break up some long lines. - fix some typos and grammar.
2016-12-05applied Markus' tagset purge of alternative view on _NET_ACTIVE_WINDOW eventAnselm R Garbe
2016-12-05applied Ivan Delalande's NET_SUPPORTING_WM_CHECK patch for gtk3 compatibilityAnselm R Garbe
2016-12-05applied Ian Remmler's man page adjustment suggestionsAnselm R Garbe
2016-12-05applied Markus' decouple color-scheme patchAnselm R Garbe
2016-12-05applied Markus' clarify status text padding patchAnselm R Garbe